Add readthedocs preview #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
approved these changes
Nov 28, 2024
Collaborator
|
Thanks! |
Collaborator
|
@rffontenelle could you please add me to the Read the Docs project? I am |
Collaborator
Author
|
Done. Invited to https://app.readthedocs.org/projects/pydocs-translation-dashboard/ |
Collaborator
|
Thanks. The preview doesn't work for https://github.com/m-aciek/pydocs-translation-dashboard/pull/15. Is there some config step required? |
Collaborator
|
Ok, I think we (you?) found the cause, the webhook integration. Let's wait for the next PR. |
Collaborator
|
Out of curiosity -- what was missing here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When on pull request, this builds the webpage in readthedocs and adds preview link.
This was suggested by @hugovk in https://github.com/m-aciek/pydocs-translation-dashboard/pull/11#issuecomment-2502998463 and inspired in CPython's solution.
Example of build with everything properly set.