Skip to content

Conversation

@merwok
Copy link

@merwok merwok commented Nov 14, 2025

fixes for #136

@merwok
Copy link
Author

merwok commented Nov 14, 2025

two things missing:

  • adapt css so that there is a top padding so we can see the full card
  • add links somewhere: the language name maybe? (I would prefer this and not # or ⛓️ emoji so that all links have a different text (accessibility rule))

@StanFromIreland
Copy link
Member

Unfortunately the CI will fail because it only properly works on branches of this repo, I will open a PR to fix it.

@StanFromIreland
Copy link
Member

StanFromIreland commented Nov 14, 2025

adapt css so that there is a top padding so we can see the full card

I with manual testing I find a scroll-margin-top: 4.5rem; looks pretty good.

@merwok
Copy link
Author

merwok commented Nov 14, 2025

Will that work if applied on the card div, not on the row?

@StanFromIreland
Copy link
Member

StanFromIreland commented Nov 15, 2025

When I tested, I added it to the card class, and it worked fine.

FYI, update the branch and the CI will go green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants