-
Notifications
You must be signed in to change notification settings - Fork 5
Deploy to subfolders for pull requests #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What's the motivation for this? |
|
Read the docs have a build timeout limit of 30 minutes. We may be breaking it if we push forward with #45 (may be not needed for that, if the parallelization will be successful). This is a proof of concept for potential switch with preview to GitHub pages. |
|
The preview returns 404 now, because the main branch deploys have a "clean" flag toggled on, so they wipe out every other file at their deploy. |
Ah right.
After toggling the flag, does this mean the repo will keep all the subfolders "forever"? Do we need a mechanism to remove old subfolders after some time? I guess it's just a couple of files per subfolder, so not such a problem. |
For the sake of cleanliness, indeed it would be worth to add some mechanism to remove subfolders. It would be probably a new workflow triggered on PR close, that would checkout the gh-pages branch, For the reference, a related discussion in the GH pages deployment GitHub repo discussions: JamesIves/github-pages-deploy-action#645 (comment). |
Lightweight version of previews.
Based on GH Pages and deploying to subdirectory (using
${{ github.ref_name }}: for pull requests:merge/[pr-number]). Adds a link only after a successful build. Removes the preview directory after the pull request close.For now I'm modifying the PR not to remove RTD just yet, rather add the second preview in every PR.
📊 Dashboard preview 📊: https://python-docs-translations.github.io/dashboard/46/merge/
📊 Dashboard preview 📊: https://python-docs-translations.github.io/dashboard/main/