Skip to content

Conversation

@m-aciek
Copy link
Collaborator

@m-aciek m-aciek commented Nov 19, 2024

@m-aciek m-aciek marked this pull request as draft November 19, 2024 23:59
@rffontenelle
Copy link
Collaborator

rffontenelle commented Nov 21, 2024

The percentages are different that I expected. For instance, pt_BR 3.13 was 63% and zh_CN was 93% (matching Transifex stats), but now they are 53 and 73%)

UPDATE: Got it, that's the whatsnew/changelog.pot adding 12K strings to the math ...

@m-aciek m-aciek marked this pull request as ready for review December 8, 2024 21:30
@m-aciek
Copy link
Collaborator Author

m-aciek commented Dec 8, 2024

I don't know a way to install gettext on Read the Docs without a sudo. Not sure, maybe we should switch to lightweight PR preview, like https://github.com/marketplace/actions/deploy-pr-preview?

@rffontenelle
Copy link
Collaborator

rffontenelle commented Dec 9, 2024

I don't think you can install using sudo in build.commands. Normally you would use build.apt_packages (see https://github.com/sphinx-doc/sphinx-doc-translations/blob/master/.readthedocs.yml#L7-L8), but AFAIK the environment of build.commands ignores such command.

See readthedocs/readthedocs.org#9599

@m-aciek
Copy link
Collaborator Author

m-aciek commented Dec 9, 2024

Read the Docs build is working after suggested changes 🎉

@m-aciek m-aciek merged commit 59a620a into main Dec 13, 2024
2 checks passed
@m-aciek m-aciek deleted the check-against-latest branch December 13, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update cloned branch against latest source strings

3 participants