Skip to content

Suggestions for new tab #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 24, 2025
Merged

Suggestions for new tab #64

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5a52e94
Put nav in right corner
StanFromIreland Feb 18, 2025
985f7c6
Add changes to meta table
StanFromIreland Feb 18, 2025
e8ad0a4
Fix & make pre-commit happy
StanFromIreland Feb 18, 2025
9f42583
Suggestion from Maciek
StanFromIreland Feb 18, 2025
9d9c803
Remove extra tag
StanFromIreland Feb 18, 2025
7b739f5
Minor improvement
StanFromIreland Feb 18, 2025
4f53ef8
increase pixels
StanFromIreland Feb 20, 2025
3b20e50
Apply suggestions from code review
StanFromIreland Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion completion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def branches_from_devguide(devguide_dir: Path) -> list[str]:

def get_completion(
clones_dir: str, repo: str
) -> tuple[float, 'TranslatorsData', str, float]:
) -> tuple[float, 'TranslatorsData', str | None, float]:
clone_path = Path(clones_dir, repo)
for branch in branches_from_devguide(Path(clones_dir, 'devguide')) + [
'master',
Expand Down
6 changes: 6 additions & 0 deletions metadata.html.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,17 @@
</head>
<body>
<h1>Python Docs Translation Dashboard</h1>
<div class="switchpages">
<nav><p><a href="index.html" target="_self">main</a> | meta</p></nav>
</div>
<table>
<thead>
<tr>
<th>language</th>
<th>branch</th>
<th>build warnings*</th>
<th>lint failures</th>
<th>30 days change</th>
</tr>
</thead>
<tbody>
Expand All @@ -28,6 +31,9 @@
<td data-label="lint">
{% if project.completion %}<a href="warnings-lint-{{ project.language.code }}.txt">{{ metadata[1] }}</a>{% else %}{{ metadata[1] }}{% endif %}
</td>
<td data-label="change">
+{{ "{:.2f}".format(project.change) }}%
</td>
</tr>
{% endfor %}
</tbody>
Expand Down
8 changes: 8 additions & 0 deletions style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ td[data-label="completion"] {
width: 100%;
line-height: 0;
}
.switchpages{
position:absolute;
top:10px;
right: 10px;
}
@media screen and (max-width: 600px) {
table, thead, tbody, th, td, tr {
display: block;
Expand Down Expand Up @@ -77,4 +82,7 @@ td[data-label="completion"] {
min-width: 0;
width: 100% !important;
}
.switchpages{
all: unset;
}
}
2 changes: 2 additions & 0 deletions template.html.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
</head>
<body>
<h1>Python Docs Translation Dashboard</h1>
<div class="switchpages">
<nav><p>main | <a href="metadata.html" target="_self">meta</a></p></nav>
</div>
<table>
<thead>
<tr>
Expand Down
2 changes: 1 addition & 1 deletion visitors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def get_number_of_visitors(language: str, http: PoolManager) -> int:
response = http.request(
'GET',
f'https://plausible.io/docs.python.org/export?{params}',
retries=Retry(status_forcelist=(500,502)),
retries=Retry(status_forcelist=(500, 502)),
)
info(f'visitors {response.status=} ({language=})')
with (
Expand Down
Loading