-
Notifications
You must be signed in to change notification settings - Fork 5
Trial translating messages with regex patterns #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trial translating messages with regex patterns #154
Conversation
|
Looking at the logs it seems to work correctly: |
|
To test this on Transifex, we can manually upload the changed POT file. Would you like to try this before moving on with review, merging etc.? |
|
Sure, do you want to do it the easy way, and just upload the file made on my system, or, upload the pot as an artefact from the workflow? |
|
Ah, it seems that there is a larger issue when tried via the web interface:
Which is interesting, I guess it must be different for the api, since the support staff did not mention it. |
|
I meant uploading POT file with the translation for a one-time test. I ran your script locally (it indeed filled the msgid with the translation and then I tried to upload to Transifex via both web UI and CLI tool. Both failed with:
For instance, from CLI: |
I bet they were talking about pushing translated msgstr from PO files, which is what the propagate_translations CI job at ci.yml does. By the way, digits might be translated as in Japanese numerals. |
|
I think I will just do this for Polish then. |
|
I see many strings consisting only of a single monospaced text (wrapped in double-backquotes). These seem to be a great candidate for your script. Thanks and sorry for not being able to implement this. Eager to see it working on pl |
Unable to get a definitive answer from TX,I propose we trial this once and see how it goes. It should translate four strings ingrp.po, which are currently untranslated in the unused German translation.I have set it up to allow us to run multiple patterns, digits+whitespace, directives like
:pep:which occasionally appear separate and in the future I would like to see an advanced codeblock filter, copying those that do not require translation per the translation style guide.From TX, this should work in theory: