Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Sep 21, 2025

Copy link
Collaborator

@rffontenelle rffontenelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for reference: python/cpython#133868

@rffontenelle rffontenelle merged commit 72f873c into python-docs-translations:main Sep 21, 2025
11 checks passed
@StanFromIreland StanFromIreland deleted the remove-grammar-text branch September 21, 2025 12:05
@AA-Turner
Copy link
Member

For future reference, please use meaningful commit titles. This has been merged (72f873c) as "Commit (#193)".

@StanFromIreland
Copy link
Member Author

I assume Rafael rebased rather than squashed.

I agree it is better, I also know I don't write commit titles during the pr process, so you can leave merging to me and I will do it then.

@AA-Turner
Copy link
Member

AA-Turner commented Sep 21, 2025

I don't write commit titles during the pr process

I'd strongly suggest starting to do so, 'commit' as a commit title is very unhelpful as a reviewer.

A

@rffontenelle
Copy link
Collaborator

yeah, it was my fault using squash & merge without double-checking the resulting commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants