Skip to content

[WIP] fix the sponge source #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zingale merged 3 commits into from
Jan 26, 2025
Merged

[WIP] fix the sponge source #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02cd168
fix the sponge source
zingale Jan 26, 2025
21bca3c
udpate compressible_rk
zingale Jan 26, 2025
ede1064
fix the sponge for 4th order
zingale Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pyro/compressible/simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,9 +427,19 @@ def evolve(self):
if self.rp.get_param("sponge.do_sponge"):
kappa_f = get_sponge_factor(self.cc_data.data, self.ivars, self.rp, myg)

U_old = self.cc_data.data.copy()

self.cc_data.data[:, :, self.ivars.ixmom] /= (1.0 + self.dt * kappa_f)
self.cc_data.data[:, :, self.ivars.iymom] /= (1.0 + self.dt * kappa_f)

# for energy, there is no change in density from the sponge, so we
# can just apply the change in kinetic energy from the velocity update
dke = 0.5 * ((self.cc_data.data[..., self.ivars.ixmom]**2 +
self.cc_data.data[..., self.ivars.iymom]**2) -
(U_old[..., self.ivars.ixmom]**2 +
U_old[..., self.ivars.iymom]**2)) / self.cc_data.data[..., self.ivars.idens]
self.cc_data.data[..., self.ivars.iener] += dke

if self.particles is not None:
self.particles.update_particles(self.dt)

Expand Down
5 changes: 5 additions & 0 deletions pyro/compressible_fv4/simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,14 @@ def substep(self, myd):
if self.rp.get_param("sponge.do_sponge"):
kappa_f = get_sponge_factor(myd.data, self.ivars, self.rp, myg)

# momentum
k.v(n=self.ivars.ixmom)[:, :] -= kappa_f.v() * myd.data.v(n=self.ivars.ixmom)
k.v(n=self.ivars.iymom)[:, :] -= kappa_f.v() * myd.data.v(n=self.ivars.iymom)

# total energy
k.v(n=self.ivars.iener)[:, :] -= kappa_f.v() * (myd.data.v(n=self.ivars.ixmom)**2 / myd.data.v(n=self.ivars.idens) +
myd.data.v(n=self.ivars.iymom)**2 / myd.data.v(n=self.ivars.idens))

return k

def preevolve(self):
Expand Down
5 changes: 5 additions & 0 deletions pyro/compressible_rk/simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,14 @@ def substep(self, myd):
if self.rp.get_param("sponge.do_sponge"):
kappa_f = compressible.get_sponge_factor(myd.data, self.ivars, self.rp, myg)

# momentum
k.v(n=self.ivars.ixmom)[:, :] -= kappa_f.v() * myd.data.v(n=self.ivars.ixmom)
k.v(n=self.ivars.iymom)[:, :] -= kappa_f.v() * myd.data.v(n=self.ivars.iymom)

# total energy
k.v(n=self.ivars.iener)[:, :] -= kappa_f.v() * (myd.data.v(n=self.ivars.ixmom)**2 / myd.data.v(n=self.ivars.idens) +
myd.data.v(n=self.ivars.iymom)**2 / myd.data.v(n=self.ivars.idens))

return k

def method_compute_timestep(self):
Expand Down
Loading