Skip to content

Update gitlab and renovate hooks to 'nonunicode' #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Update gitlab and renovate hooks to 'nonunicode' #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pre-commit-hooks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
- id: check-gitlab-ci
name: Validate GitLab CI config
description: 'Validate GitLab CI config against the schema provided by SchemaStore'
entry: check-jsonschema --builtin-schema vendor.gitlab-ci --data-transform gitlab-ci
entry: check-jsonschema --builtin-schema vendor.gitlab-ci --data-transform gitlab-ci --regex-variant nonunicode
language: python
files: ^.*\.gitlab-ci\.yml$
types: [yaml]
Expand Down Expand Up @@ -196,7 +196,7 @@
- id: check-renovate
name: Validate Renovate Config
description: 'Validate Renovate config against the schema provided by Renovate (does not support renovate config in package.json)'
entry: check-jsonschema --builtin-schema vendor.renovate
entry: check-jsonschema --builtin-schema vendor.renovate --regex-variant nonunicode
language: python
files: >
(?x)^(
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ Unreleased
.. vendor-insert-here

- Update vendored schemas (2025-01-26)
- Update the ``gitlab`` and ``renovate`` hooks to use
``--regex-variant nonunicode``. Thanks :user:`quentin-ag` and :user:`Callek`
for reporting! (:issue:`516`, :issue:`518`)

0.31.0
------
Expand Down
8 changes: 7 additions & 1 deletion src/check_jsonschema/catalog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,12 @@ def _githubusercontent_url(owner: str, repo: str, ref: str, path: str) -> str:
),
"hook_config": {
"name": "Validate GitLab CI config",
"add_args": ["--data-transform", "gitlab-ci"],
"add_args": [
"--data-transform",
"gitlab-ci",
"--regex-variant",
"nonunicode",
],
"files": r"^.*\.gitlab-ci\.yml$",
"types": "yaml",
},
Expand Down Expand Up @@ -198,6 +203,7 @@ def _githubusercontent_url(owner: str, repo: str, ref: str, path: str) -> str:
"Validate Renovate config against the schema provided by "
"Renovate (does not support renovate config in package.json)"
),
"add_args": ["--regex-variant", "nonunicode"],
"files": [
r"renovate\.(json|json5)",
r"\.(github|gitlab)/renovate\.(json|json5)",
Expand Down
Loading