Skip to content

Test expected positive types and types_or matches #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2025
Merged

Test expected positive types and types_or matches #544

merged 2 commits into from
Mar 27, 2025

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Mar 26, 2025 •
edited
Loading

Should at least prevent some false negatives.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review March 26, 2025 14:58
sirosen
sirosen approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@sirosen sirosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work and good idea! I was thinking we needed to do more here, but this is a solid basic check that at least makes sure we catch mistakes like the one we just had.

It gives me great pleasure to approve and merge this. 😁

@sirosen sirosen merged commit 7689a14 into python-jsonschema:main Mar 27, 2025
23 checks passed
@edgarrmondragon edgarrmondragon deleted the test-good-types-types_or branch March 27, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sirosen sirosen sirosen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edgarrmondragon @sirosen