Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
strategy:
matrix:
os: [ubuntu, windows, macos]
py: ['3.9', '3.10', '3.11', '3.12', '3.13']
py: ['3.9', '3.10', '3.11', '3.12', '3.13', '3.14']
name: "Test on ${{ matrix.os }}, py${{ matrix.py }}"
runs-on: "${{ matrix.os }}-latest"
steps:
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ CHANGELOG
Unreleased
----------

- Add official support for Python 3.14

.. vendor-insert-here

- Update vendored schemas: circle-ci, compose-spec, dependabot, meltano, mergify,
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/test_cachedownloader.py
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,10 @@ def dummy_validate_bytes(data):
assert validator_ran is False


@pytest.mark.skipif(
platform.system() == "Windows",
reason="time.tzset() is not available on Windows",
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 I should probably go back over the test to figure out a compatible way of setting the timezone. But this will do for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, FWIW I noticed this on main (e.g. https://github.com/python-jsonschema/check-jsonschema/actions/runs/19238976727/job/54996498981) and thought it was a good idea to handle it in this PR.

I don't know of any good alternatives for monkeypatching the timezone, unfortunately 😕.

def test_lastmod_from_header_uses_gmtime(request, monkeypatch, default_response):
"""
Regression test for https://github.com/python-jsonschema/check-jsonschema/pull/565
Expand Down
8 changes: 4 additions & 4 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ envlist =
mypy
cov_clean
py39-mindeps{,-format}
py{313,312,311,310,39}
py{39,313}-{json5,pyjson5}{,-format}
py{39,313}-{disable_orjson}
py{314,313,312,311,310,39}
py{39,314}-{json5,pyjson5}{,-format}
py{39,314}-{disable_orjson}
cov_combine
cov_report
skip_missing_interpreters = true
Expand Down Expand Up @@ -45,7 +45,7 @@ description = "combine coverage data"
deps = coverage
skip_install = true
commands = coverage combine
depends = py{,38,39,310,311,312,313}{,-mindeps,-format,-json5,-pyjson5,-disable_orjson}
depends = py{,39,310,311,312,313,314}{,-mindeps,-format,-json5,-pyjson5,-disable_orjson}

[testenv:cov_report]
description = "report test coverage"
Expand Down
Loading