Skip to content

fix zipfile.py 'UserWarning: Duplicate name: docProps/core.xml' #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+17 −3
Open

fix zipfile.py 'UserWarning: Duplicate name: docProps/core.xml' #1436

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
049572e
fix zipfile.py 'UserWarning: Duplicate name: docProps/core.xml'
Oct 1, 2024
bbe7d62
remap core-properties namespace from ../officedocument/.. to ../packa…
Oct 7, 2024
9cd7256
use proper setter for reltype
cip91sk May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/docx/opc/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,10 @@ class RELATIONSHIP_TYPE:
"http://schemas.openxmlformats.org/package/2006/relationships/metada"
"ta/core-properties"
)
CORE_PROPERTIES_OFFICEDOCUMENT = (
"http://schemas.openxmlformats.org/officedocument/2006/relationships"
"/metadata/core-properties"
)
CUSTOM_PROPERTIES = (
"http://schemas.openxmlformats.org/officeDocument/2006/relationships"
"/custom-properties"
Expand Down
12 changes: 9 additions & 3 deletions src/docx/opc/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,15 @@ def _core_properties_part(self) -> CorePropertiesPart:
try:
return cast(CorePropertiesPart, self.part_related_by(RT.CORE_PROPERTIES))
except KeyError:
core_properties_part = CorePropertiesPart.default(self)
self.relate_to(core_properties_part, RT.CORE_PROPERTIES)
return core_properties_part
try:
office_document_part = self.part_related_by(RT.CORE_PROPERTIES_OFFICEDOCUMENT)
rel = self.relate_to(office_document_part, RT.CORE_PROPERTIES_OFFICEDOCUMENT)
self.rels[rel].set_reltype(RT.CORE_PROPERTIES)
Copy link

@keestux keestux Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First see below how to create a setter. Then change this line to

self.rels[rel].reltype = RT.CORE_PROPERTIES

return cast(CorePropertiesPart, office_document_part)
except KeyError:
core_properties_part = CorePropertiesPart.default(self)
self.relate_to(core_properties_part, RT.CORE_PROPERTIES)
return core_properties_part


class Unmarshaller:
Expand Down
3 changes: 3 additions & 0 deletions src/docx/opc/rel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@ def is_external(self) -> bool:
def reltype(self) -> str:
return self._reltype

def set_reltype(self, reltype:str) -> None:
self._reltype = reltype
Copy link

@keestux keestux Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a setter

    @reltype.setter
    def reltype(self, value: str):
        self._reltype = value


@property
def rId(self) -> str:
return self._rId
Expand Down