Skip to content

Improved BCn overflow check #9043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improved BCn overflow check #9043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libImaging/BcnEncode.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,9 +257,9 @@

UINT8 *dst = buf;

int will_write = (n == 2 || n == 3 || n == 5) ? 16 : 8;

Check warning on line 260 in src/libImaging/BcnEncode.c

View check run for this annotation

Codecov / codecov/patch

src/libImaging/BcnEncode.c#L260 

Added line #L260 was not covered by tests
for (;;) {
// Loop writes a max of 16 bytes per iteration
if (dst + 16 >= bytes + buf) {
if (dst + will_write >= bytes + buf) {
break;
}
if (n == 5) {
Expand Down
Loading