Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageDraw.multiline_text
currently takes 14 arguments, andImageDraw.multiline_textbbox
currently accepts 12 arguments.#6201 would probably lead to that number increasing further, and there are some comments that wonder why calculating multiline text bounding box dimensions requires an ImageDraw instance.
I'm going to suggest adding a new
ImageText
class. I consider this to be a tidying of the API, rather than something motivated by a pressing need, so if this is accepted, maybe we don't need an immediate deprecation.Before
After
New features like #6201 would be made exclusive to the new class, something like
text.wrap(width, height, scaling, limit)
.If nothing else, this will separate the text handling logic from the rest of the ImageDraw code.