-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add manylinux_2_28 ppc64le wheels #9145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just following up on regarding the ppc64le wheels. Are there any updates or feedback needed to move it forward? |
Simply waiting for review from another Pillow team member. |
@sandeepgupta12 Can you test these wheels before we merge ? |
Sure, I can test the wheels on a ppc64le machine and let you know the results. |
@radarhere
Looking at the build script, on ppc64le the build function runs build_libjpeg_turbo but then exits early: if [[ "$AUDITWHEEL_ARCH" == "ppc64le" ]]; then
return
fi Because of this, other dependencies are not built, so the resulting wheel has incomplete image format support. That seems to explain the above test failures. |
I would be surprised if the lack of image support was the reason for the test failures. The test failures sound more like #9088, which was merged after the last time I updated this PR. So I suspect the problem is that you built from this PR, and then tested main. To simplify things, I've now merged main into this PR again, so that change should now be included. Could you try building and testing again? |
@radarhere @aclark4life Thanks for updating the branch. I retested on a native ppc64le machine, and everything is working fine now ✅. I think we can go ahead and merge this PR. |
How long does this take to build? How many wheels does it create? How big are they? |
Oops, accidentally deleted this branch. I've recreated it in #9216 The longest run is 1h 1m. This creates 7 manylinux_2_28 wheels (all active CPython versions, including threaded). They are each 1.9mb. |
#9107 requests ppc64le wheels.
While there is the potential for using self-hosted runners to generate these quickly, if we don't want to go down that route, then here is another option - using QEMU to create them, but with minimal dependencies to reduce the build time. In the build in this PR, ppc64le jobs are not the longest.