Skip to content

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Oct 12, 2025

Alternative to #9248

Normally, our scheduled Wheels jobs update wheels to scientific-python-nightly-wheels - https://github.com/python-pillow/Pillow/actions/runs/18331606908

Our most recent scheduled Wheels jobs did not - https://github.com/python-pillow/Pillow/actions/runs/18437781793

This is because #9239 made 'scientific-python-nightly-wheels-publish' require 'count-dists', which requires 'sdist', but 'sdist' does not run when scheduled.

This PR suggests always running 'sdist', but if the jobs are scheduled, skip all the steps within it.

@hugovk
Copy link
Member

hugovk commented Oct 12, 2025

Why does 'sdist' does not run when scheduled? To only upload wheels to scientific-python-nightly-wheels and avoid a ~50 MB zip?


Or perhaps unhook the 'count-dists' check from the scientific-python-nightly-wheels flow?

image

@radarhere
Copy link
Member Author

Why does 'sdist' does not run when scheduled? To only upload wheels to scientific-python-nightly-wheels and avoid a ~50 MB zip?

It turns out I suggested it a year ago. I expect I just thought it wasn't necessary to upload it. If you'd like to though, I have no objection. I've created #9248

Or perhaps unhook the 'count-dists' check from the scientific-python-nightly-wheels flow?

All other things being equal, I think it would be better to know if we suddenly start uploading extra wheels to scientific-python-nightly-wheels.

@hugovk
Copy link
Member

hugovk commented Oct 12, 2025

Why does 'sdist' does not run when scheduled? To only upload wheels to scientific-python-nightly-wheels and avoid a ~50 MB zip?

It turns out I suggested it a year ago. I expect I just thought it wasn't necessary to upload it. If you'd like to though, I have no objection. I've created #9248

I checked a few others at https://anaconda.org/scientific-python-nightly-wheels/ and didn't see any sdist, so probably better not to upload a fairly large file. And the clue's in the (scientific-python-nightly-wheels) name.

Or perhaps unhook the 'count-dists' check from the scientific-python-nightly-wheels flow?

All other things being equal, I think it would be better to know if we suddenly start uploading extra wheels to scientific-python-nightly-wheels.

Agreed.

How about we use #9248 and do something like rm pillow*.tar.gz in the scientific-python-nightly-wheels-publish job just before upload?

@radarhere
Copy link
Member Author

radarhere commented Oct 12, 2025

How about we use #9248 and do something like rm pillow*.tar.gz in the scientific-python-nightly-wheels-publish job just before upload?

Sure. I've updated the PR, just changing the 'pattern' used for matching in scientific-python-nightly-wheels-publish.

@hugovk
Copy link
Member

hugovk commented Oct 13, 2025

Closed in favour of #9248.

@hugovk hugovk closed this Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants