Simplified code

[radarhere]

Perhaps this is just me, but reading

Pillow/src/encode.c

Line 235 in e2b87a0

if (!PyArg_ParseTuple(args, "O|(nnnn)", &op, &x0, &y0, &x1, &y1)) {

Pillow/src/encode.c

Lines 247 to 255 in e2b87a0

	if (x0 == 0 && x1 == 0) {
	state->xsize = im->xsize;
	state->ysize = im->ysize;
	} else {
	state->xoff = x0;
	state->yoff = y0;
	state->xsize = x1 - x0;
	state->ysize = y1 - y0;
	}

my reaction is

Why if x0 and x1 are zero? If we're encoding an image with zero width, then use the full image size? That seems odd. Also, what if it is zero height?

The code has been like this since PIL. I suspect the intention was to handle

Pillow/src/PIL/Image.py

Line 787 in e2b87a0

e.setimage(self.im)

where no extents are passed in, and say that in that scenario, the extents should default to the entire image.

I think it would simpler if we just explicitly passed that in from Python.