Skip to content

Updated GitHub Actions to ubuntu-latest #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Updated GitHub Actions to ubuntu-latest #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ad22f3
Updated GitHub Actions to ubuntu-latest
radarhere Aug 11, 2023
ab29b93
Updated Python versions
radarhere Aug 11, 2023
444e32f
Allow constant removed in Pillow 10.0.0 to be absent
radarhere Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ jobs:
fail-fast: false
matrix:
python-version: [
"pypy-3.7",
"pypy-3.8",
"3.9",
"pypy-3.9",
"pypy-3.10",
"3.10",
"3.11",
]
os: [ubuntu-18.04]
os: [ubuntu-latest]

steps:
- uses: actions/checkout@v3
Expand Down
3 changes: 2 additions & 1 deletion testsuite/cases/pillow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
from .base import BaseTestCase, root


Image.LANCZOS = Image.ANTIALIAS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pillow-perf intended to work with all versions of Pillow, not only the latest, and even with versions before Image.LANCZOS introduced.

if hasattr(Image, "ANTIALIAS"):
    Image.LANCZOS = Image.ANTIALIAS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have thought this line isn't needed, regardless of the Pillow version, because neither LANCZOS or ANTIALIAS is used in the rest of this file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually used

if hasattr(Image, "ANTIALIAS"):
Image.LANCZOS = Image.ANTIALIAS


class PillowTestCase(BaseTestCase):
Expand Down