Skip to content

Fix CI, update pyproject.toml and version#804

Merged
Secrus merged 2 commits intopython-poetry:mainfrom
Secrus:fix-ci
Jan 6, 2025
Merged

Fix CI, update pyproject.toml and version#804
Secrus merged 2 commits intopython-poetry:mainfrom
Secrus:fix-ci

Conversation

@Secrus
Copy link
Member

@Secrus Secrus commented Jan 6, 2025

Summary by Sourcery

CI:

  • Use poetry check --lock instead of poetry lock --check.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 6, 2025

Reviewer's Guide by Sourcery

This pull request fixes the lock check command in the CI workflow to use the correct poetry check --lock command.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the lock check command
  • Replaced poetry lock --check with poetry check --lock
.github/workflows/tests.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Secrus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Secrus Secrus changed the title Fix lock check command in CI Fix CI, update pyproject.toml and version Jan 6, 2025
@Secrus Secrus force-pushed the fix-ci branch 2 times, most recently from 3a77159 to 983f159 Compare January 6, 2025 13:49
def test_version_is_synced() -> None:
pyproject = PyProjectTOML(Path(__file__).parent.parent.joinpath("pyproject.toml"))
assert __version__ == pyproject.poetry_config.get("version")
assert __version__ == pyproject.data["project"]["version"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope for this change but we should expose pyproject.version etc.

@Secrus Secrus merged commit 61081dd into python-poetry:main Jan 6, 2025
17 checks passed
@Secrus Secrus deleted the fix-ci branch January 6, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants