Merged
Conversation
Reviewer's Guide by SourceryThis pull request updates the version to 2.0.1, replaces a deprecated metadata field in the changelog, and fixes several KeyError issues related to project configuration. Flow diagram of version update changesgraph TD
A[Version 2.0.1.dev0] -->|Update version| B[Version 2.0.1]
C[Home-page metadata field] -->|Replace deprecated field| D[Project-URL: Homepage]
E[KeyError fixes] -->|Fix 1| F[Initialize default format for tool.poetry.packages]
E -->|Fix 2| G[Process project.urls entries correctly]
E -->|Fix 3| H[Handle dynamic project.dependencies with optional-dependencies]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @radoering - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
abn
approved these changes
Jan 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
Home-pagewithProject-URL: Homepage(#807).Fixed
tool.poetry.packageswithout a specifiedformatwere not initialized with the default value resulting in aKeyError(#805).project.urlsentries were not processed correctly resulting in aKeyError(#807).project.dependenciesviatool.poetry.dependencieswere ignored ifproject.optional-dependencieswere defined (#811).Summary by Sourcery
Bump version to 2.0.1 and address several bug fixes related to metadata processing and dependency handling. Replace deprecated metadata field with a new standard.
Bug Fixes:
tool.poetry.packageswithout a specifiedformatwere not initialized with the default value, resulting in aKeyError.project.urlsentries were not processed correctly, resulting in aKeyError.project.dependenciesviatool.poetry.dependencieswere ignored ifproject.optional-dependencieswere defined.Enhancements:
Home-pagewithProject-URL: Homepage.Chores: