Skip to content

Conversation

@radoering
Copy link
Member

@radoering radoering commented Sep 14, 2025

Summary by Sourcery

Update development dependencies and adjust a type ignore annotation in the version union implementation.

Enhancements:

  • Refined type ignore directive for the sort call in version_union.py to use call-arg instead of call-overload.

Chores:

  • Updated development dependencies in the Poetry lockfile.

@sourcery-ai
Copy link

sourcery-ai bot commented Sep 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refreshes development dependencies by regenerating the lock file and corrects a mypy ignore annotation in VersionUnion sorting to use the appropriate ignore code.

File-Level Changes

Change Details Files
Fix type ignore code for flattened.sort() in version_union
  • Changed type ignore from call-overload to call-arg on the sort call
src/poetry/core/constraints/version/version_union.py
Regenerate lock file to update dev dependencies
  • Regenerated poetry.lock to bump development package versions
poetry.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering radoering merged commit 614a980 into python-poetry:main Sep 14, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant