Skip to content

Conversation

@dotlambda
Copy link

@dotlambda dotlambda commented Nov 10, 2025

Summary by Sourcery

Remove unused pytest venv fixture and drop virtualenv dependency from project configuration

Chores:

  • Remove the venv fixture from tests/conftest.py
  • Remove virtualenv from pyproject.toml dependencies and poetry.lock
  • Update typing exclusion list to remove virtualenv.*

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 10, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes the now-unused venv fixture in tests and cleans up project configuration by dropping the virtualenv dependency (adjusting pyproject.toml and poetry.lock accordingly).

File-Level Changes

Change Details Files
Removed unused venv fixture from tests
  • Deleted the venv pytest fixture definition
  • Removed the virtualenv.cli_run invocation for creating venv
tests/conftest.py
Dropped virtualenv dependency from project configuration
  • Removed virtualenv from pyproject.toml dependencies
  • Removed virtualenv from the exclusion list in pyproject.toml
  • Updated poetry.lock to reflect removal of virtualenv
pyproject.toml
poetry.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The python fixture still depends on the removed venv fixture—either restore the venv fixture or update python to not require it to avoid broken tests.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The python fixture still depends on the removed venv fixture—either restore the venv fixture or update python to not require it to avoid broken tests.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dotlambda dotlambda closed this Nov 10, 2025
@dotlambda
Copy link
Author

Didn't notice that I'm not running integration tests.

@dotlambda dotlambda deleted the virtualenv branch November 10, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant