make use of locked markers in lock file version 2.1 and thereby avoid dependency walk failed
#286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
radoering
force-pushed
the
dependency-walk-failed
branch
2 times, most recently
from
e2cdfad to
7a89609
Compare
|
This does resolve the long-standing issue with |
|
Very interested, we have been having issues with urllib3 as well |
radoering
force-pushed
the
dependency-walk-failed
branch
from
7a89609 to
42c96c1
Compare
radoering
force-pushed
the
dependency-walk-failed
branch
2 times, most recently
from
6a992f7 to
9feaa40
Compare
|
radoering
force-pushed
the
dependency-walk-failed
branch
2 times, most recently
from
568bf9f to
fd8a2de
Compare
radoering
force-pushed
the
dependency-walk-failed
branch
from
fd8a2de to
ac2addc
Compare
radoering
force-pushed
the
dependency-walk-failed
branch
from
ac2addc to
9e30454
Compare
radoering
force-pushed
the
dependency-walk-failed
branch
from
9e30454 to
164904a
Compare
radoering
force-pushed
the
dependency-walk-failed
branch
from
164904a to
34e9f85
Compare
|
Hey! I'm not sure how this repository works. What would be needed to get this Pull Request going? It would be great to solve the longstanding #183 |
radoering
force-pushed
the
dependency-walk-failed
branch
from
34e9f85 to
42f0f17
Compare
|
Member
Author
It requires a Poetry release that includes python-poetry/poetry#9427. That will be python-poetry/poetry#9448. |
radoering
force-pushed
the
dependency-walk-failed
branch
from
42f0f17 to
98ddb57
Compare
radoering
force-pushed
the
dependency-walk-failed
branch
from
98ddb57 to
1a8352e
Compare
… `dependency walk failed`
radoering
force-pushed
the
dependency-walk-failed
branch
from
1a8352e to
e67e454
Compare
|
abn
approved these changes
Jan 5, 2025
6 tasks
wgreenberg
pushed a commit
to certbot/certbot
that referenced
this pull request
Feb 6, 2025
…s issue and unpin urllib3 (#10169) We can use modern urllib3 now! They [fixed](python-poetry/poetry-plugin-export#286) the poetry [issue](python-poetry/poetry-plugin-export#183) and shipped it! Since this PR updates the requirements file, it pulls in the new `josepy` release, so I've silenced those warnings here. If I should do that in a separate PR lmk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #176
Resolves: #183
Requires: python-poetry/poetry#9427
With python-poetry/poetry#9427 we can fix
dependency walk failedonce and for all. The dependency walker becomes as simple as iterating over a flat list and doing some simple marker operations. There is no complicated erroneous logic anymore because the resulting markers for each locked package can be read from the lock file.I adapted all tests so they are run with an old lock file without markers and with a new lock file with markers and added a test (at the end) that raises
dependency walk failedfor an old lock file and succeeds for a new lock file.