Skip to content

Conversation

@radoering
Copy link
Member

@radoering radoering commented Dec 11, 2025

Summary by Sourcery

Ensure git backend tests use a repository with a fixed 'main' default branch and update related expectations to be independent of external git default-branch settings.

Tests:

  • Initialize temporary git test repositories with 'main' as the default branch to decouple tests from environment-specific git settings.
  • Adjust clone error expectation to reference 'refs/heads/main' instead of 'refs/heads/master' in git backend tests.

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 11, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR makes the Git-based tests independent of the environment’s default branch by explicitly initializing test repositories with 'main' as the default branch and updating the corresponding expected error message to reference 'refs/heads/main' instead of 'refs/heads/master'.

File-Level Changes

Change Details Files
Ensure temporary dulwich test repositories use a deterministic default branch name.
  • Initialize the temporary dulwich repository with an explicit default_branch argument set to b'main' instead of relying on dulwich’s default.
  • Keep the rest of the temp_repo fixture behavior (worktree retrieval and commit setup) unchanged.
tests/vcs/git/conftest.py
Align test expectations with the new default branch name used during cloning failures.
  • Update the expected error message in the clone-existing-locked-tag test to assert against 'refs/heads/main' instead of 'refs/heads/master'.
  • Keep the rest of the test logic and assertions unchanged.
tests/vcs/git/test_backend.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • To truly decouple the test from a specific default branch name, consider deriving the expected ref from the created repo (e.g., using repo.default_branch or a fixture parameter) instead of hardcoding 'main' in the error message assertion.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- To truly decouple the test from a specific default branch name, consider deriving the expected ref from the created repo (e.g., using `repo.default_branch` or a fixture parameter) instead of hardcoding `'main'` in the error message assertion.

## Individual Comments

### Comment 1
<location> `tests/vcs/git/test_backend.py:279` </location>
<code_context>

     expected_short = (
-        f"Failed to clone {source_url} at 'refs/heads/master',"
+        f"Failed to clone {source_url} at 'refs/heads/main',"
         f" unable to acquire file lock for {tag_ref}."
     )
</code_context>

<issue_to_address>
**suggestion (testing):** The assertion on the exact error string is quite brittle; consider relaxing it to focus on the important parts.

`assert str(exc_info.value) == expected_short` ties the test to the exact wording (including punctuation and spacing), so minor message refactors will break it even if behavior is unchanged. Prefer asserting on key substrings (e.g., branch ref and lock path) or using a regex so the test verifies `refs/heads/main` and the tag lock are mentioned without over-constraining the full message.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering
Copy link
Member Author

radoering commented Dec 11, 2025

pre-commit.ci autofix

@radoering radoering merged commit c1e189d into python-poetry:main Dec 12, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant