Skip to content

exception guard on rename #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
georgeharker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

exception guard on rename #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 33 additions & 21 deletions pylsp_rope/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,27 +184,39 @@ def pylsp_rename(
if not cfg.get("rename", False):
return None

logger.info("textDocument/rename: %s %s %s", document, position, new_name)
project = new_project(workspace) # FIXME: we shouldn't have to always keep creating new projects here
document, resource = get_resource(workspace, document.uri, project=project)

rename = Rename(
project=project,
resource=resource,
offset=document.offset_at_position(position),
)
try:
logger.info("textDocument/rename: %s %s %s", document, position, new_name)
project = new_project(workspace) # FIXME: we shouldn't have to always keep creating new projects here
document, resource = get_resource(workspace, document.uri, project=project)

rename = Rename(
project=project,
resource=resource,
offset=document.offset_at_position(position),
)

logger.debug(
"Executing rename of %s to %s",
document.word_at_position(position),
new_name,
)
logger.debug(
"Executing rename of %s to %s",
document.word_at_position(position),
new_name,
)

rope_changeset = rename.get_changes(new_name, in_hierarchy=True, docs=True)
rope_changeset = rename.get_changes(new_name, in_hierarchy=True, docs=True)

logger.debug("Finished rename: %s", rope_changeset.changes)
workspace_edit = rope_changeset_to_workspace_edit(
workspace,
rope_changeset,
)
return workspace_edit
logger.debug("Finished rename: %s", rope_changeset.changes)
workspace_edit = rope_changeset_to_workspace_edit(
workspace,
rope_changeset,
)
return workspace_edit
except Exception as exc:
logger.exception(
"Exception when doing workspace/executeCommand: %s",
str(exc),
exc_info=exc,
)
workspace.show_message(
f"pylsp-rope: {exc}",
msg_type=MessageType.Error,
)
return None