Skip to content

Fix behavior when patch removes null uneditable fields #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions scim2_server/operators.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,16 +258,17 @@ class RemoveOperator(Operator):
@classmethod
def operation(cls, model: BaseModel, attribute: str, value: Any):
alias = get_by_alias(type(model), attribute)
existing_value = getattr(model, alias)
if not existing_value:
return

if model.get_field_annotation(alias, Mutability) in (
Mutability.read_only,
Mutability.immutable,
):
raise SCIMException(Error.make_mutability_error())

existing_value = getattr(model, alias)
if not existing_value:
return

if model.get_field_annotation(alias, Required) == Required.true:
raise SCIMException(Error.make_invalid_value_error())

Expand Down
10 changes: 10 additions & 0 deletions tests/test_operators.py
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,16 @@ def test_simple_remove_operator_immutable(self):
with pytest.raises(SCIMException, match="immutable"):
RemoveOperator.operation(u, "groups", None)

def test_remove_operator_mutability_validation_on_empty_fields(self):
"""Test that mutability constraints are enforced even on empty/unset fields."""
u = User(id="123") # groups field is None/empty by default
with pytest.raises(SCIMException, match="mutability"):
RemoveOperator.operation(u, "groups", None)

u2 = User() # id field is None/empty by default
with pytest.raises(SCIMException, match="mutability"):
RemoveOperator.operation(u2, "id", None)

def test_remove_operator_root_object(self):
u = User()
with pytest.raises(SCIMException, match="noTarget"):
Expand Down
Loading