Add support to SOCIAL_AUTH_OIDC_PROMPT and others#1127
Conversation
|
A PR with documentation was sent, see python-social-auth/social-docs#288. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1127 +/- ##
==========================================
- Coverage 77.87% 77.75% -0.12%
==========================================
Files 353 353
Lines 10794 10854 +60
Branches 471 485 +14
==========================================
+ Hits 8406 8440 +34
- Misses 2222 2241 +19
- Partials 166 173 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nijel
left a comment
nijel
left a comment
There was a problem hiding this comment.
If warnings were meant to indicate errors in the configuration, I think it's better to fail directly. Nobody will notice warnings.
As for the tests, it could check whether the configured parameters are included in the request to the authentication server.
rgaiacs
force-pushed
the
1124-add-openid-connect-optional-parameter
branch
from
ea244d6 to
36e841d
Compare
rgaiacs
changed the title
|
Thanks for the feedback. I expanded to match the list of parameters explicitly mentioned in the Authentication Request section. I don't implemented all parameters because of my limited knowledge of OpenID. |
|
New exceptions were defined. |
| display = self.setting("DISPLAY", default=self.DISPLAY) | ||
| if display is not None: | ||
| if not display: | ||
| raise AuthMissingParameter("OpenID Connect display value cannot be empty string.") |
There was a problem hiding this comment.
AFAIK these should take self as a first parameter.
* Add documentation of optional parameter in OpenID Connect Related to python-social-auth/social-core#1124 Supplement python-social-auth/social-core#1127 * fix permissions --------- Co-authored-by: Michal Čihař <michal@cihar.com>
|
Merged, thanks for your contribution! |
2 participants
This is related to #1124.
This is my first PR to this project. Feedback is welcome, specially regarding
If this PR looks good, I will submit others to complete #1124.