Skip to content

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented May 23, 2025

#321 intended to move changelog/version checks to pre-commit, but it also removed tagging releases.. without reintroducing that anywhere else.

shoutout to @A5rocks for noticing

We could perhaps do the tagging in pre-commit as well, but that would require contributors to remember to push with --tag.

We could go back and "manually" create tags for all past releases since #321, but I'm not sure there's much reason to? But if it's to be done it should be done now before we start to create new tags

@A5rocks
Copy link

A5rocks commented May 23, 2025

But if it's to be done it should be done now before we start to create new tags

Not necessarily, lightweight tags (not the ones GitHub makes for you) get marked as created at the same time as the commit they tag.

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth keeping the check_release job, so that we get feedback on this before merging? Otherwise LGTM

@jakkdl
Copy link
Member Author

jakkdl commented May 26, 2025

I think it's worth keeping the check_release job, so that we get feedback on this before merging? Otherwise LGTM

this check is also in pre-commit, so we're fully duplicating the same test in two places without any benefit.

@jakkdl jakkdl merged commit af6f28f into python-trio:main May 26, 2025
10 checks passed
@jakkdl jakkdl deleted the unbreak_tags branch May 26, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants