Skip to content

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Apr 3, 2025

ticks off one docstring from #3221

property added in #3010

@jakkdl jakkdl requested a review from A5rocks April 3, 2025 08:07
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.17639%. Comparing base (d988edd) to head (691bf8b).
Report is 116 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##                main       #3241   +/-   ##
=============================================
  Coverage   56.17639%   56.17639%           
=============================================
  Files            246         246           
  Lines          37530       37530           
  Branches        2538        2538           
=============================================
  Hits           21083       21083           
  Misses         16319       16319           
  Partials         128         128           
Files with missing lines Coverage Δ
src/trio/_core/_run.py 100.00000% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakkdl jakkdl added the skip newsfragment Newsfragment is not required label Apr 3, 2025
Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole "Read-write, :class:`float`" thing is weird but I guess we should follow conventions... Makes sense to me.

@A5rocks A5rocks merged commit 5848b41 into python-trio:main Apr 5, 2025
42 of 44 checks passed
@jakkdl
Copy link
Member Author

jakkdl commented Apr 7, 2025

The whole "Read-write, :class:float" thing is weird but I guess we should follow conventions... Makes sense to me.

yeah I don't love it. And I don't think we're following that convention in all our docstrings. But /shrug

@jakkdl jakkdl deleted the rel_deadline_docstring branch April 7, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newsfragment Newsfragment is not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants