Issue 2077 playwright #2083
Closed
Issue 2077 playwright #2083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disabled the docstring-is-first test for the examples directory, since it gives false positives due to streamlit's magic strings.
Member
|
I like the idea of testing PR's and main branch Folium against the test suites of downstream packages. That should give us a lot more certainty. But wouldn't it be nice if we can do that without copying their test code? I imagine we can make a Github Actions pipeline that has the relevant Folium branch, pulls their repo and dev dependencies, then runs their tests. That way we would have the best of both worlds: their tests without their test code. |
Collaborator
Author
|
That makes sense. I guess we could try to do something similar with packages such as |
Member
Yes, agreed. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use playwright and an example streamlit app for testing Folium maps.