Skip to content

Conversation

@hansthen
Copy link
Collaborator

This solves an issue with the build

This solves an issue with the build
@hansthen hansthen requested a review from Conengmo February 27, 2025 06:29
@hansthen
Copy link
Collaborator Author

@Conengmo Are you up for code reviews? You complained about being very busy a few weeks ago. I fixed a problem with the build due to a new sphinx version. It is a fairly small change that does not affect the main library functionality. If I don't hear from you, I will merge this myself soon.

selenium<4.27.0
setuptools_scm
sphinx
sphinx==7.3.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the errors with the newer versions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exception: module 'sphinx.util' has no attribute 'console'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check that next week. Let's merge this one for now. Thanks!

@ocefpaf ocefpaf merged commit f9b00cd into python-visualization:main Mar 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants