Skip to content

Verify if is a websocket connection #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Verify if is a websocket connection #1443

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27de2b8
verify if is a websocket connection
MauroAntonino Feb 21, 2024
96c273e
fix websocket header verificationƒ
MauroAntonino Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/websockets/sync/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,14 @@ def __exit__(
) -> None:
self.shutdown()

def is_websocket(connection):
"""
return True if the connection is a websocket

"""
upgrade_header = connection.__dict__.get('request').headers.get('Upgrade', '')
connection_header = connection.__dict__.get('request').headers.get('Connection', '')
return upgrade_header.lower() == 'websocket' and connection_header.lower() == 'upgrade'

def serve(
handler: Callable[[ServerConnection], None],
Expand Down Expand Up @@ -508,7 +516,8 @@ def protocol_select_subprotocol(
return

try:
handler(connection)
if is_websocket(connection):
handler(connection)
except Exception:
protocol.logger.error("connection handler failed", exc_info=True)
connection.close(CloseCode.INTERNAL_ERROR)
Expand Down