Skip to content

Replaceing the metadata parser from packaging.metadata #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Replaceing the metadata parser from packaging.metadata #607

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdada13
Using the metadata parser packaging.metadata
LalatenduMohanty Jul 4, 2025
0fc5526
Migrate candidate.py to use packaging.metadata.Metadata
LalatenduMohanty Jul 7, 2025
d948afc
Make dependencies.py metadata parsing consistent with other files
LalatenduMohanty Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/fromager/bootstrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
import tempfile
import typing
import zipfile
from email.parser import BytesParser
from urllib.parse import urlparse

from packaging.metadata import Metadata, parse_email
from packaging.requirements import Requirement
from packaging.utils import NormalizedName, canonicalize_name
from packaging.version import Version
Expand Down Expand Up @@ -784,9 +784,9 @@ def _get_version_from_package_metadata(
)
metadata_filename = source_dir.parent / metadata_dir_base / "METADATA"
with open(metadata_filename, "rb") as f:
p = BytesParser()
metadata = p.parse(f, headersonly=True)
return Version(metadata["Version"])
raw_metadata, _ = parse_email(f.read())
metadata = Metadata.from_raw(raw_metadata)
Comment on lines +787 to +788
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you using parse_email() + Metadata.from_raw() instead of Metadata.parse_email()? The Metadata.parse_email() combines parse_email(), Metadata.from_raw(), and additional validation.

This code should probably use fromager.dependencies.parse_metadata(metadata_filename).

return metadata.version

def _resolve_prebuilt_with_history(
self,
Expand Down
Loading