✨ feat: HTTP retry mechanism for network resilience #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilienM
force-pushed
the
issue_222
branch
2 times, most recently
from
0022f44 to
f4d2080
Compare
|
I forgot proper unit tests, marking as draft again. |
EmilienM
force-pushed
the
issue_222
branch
2 times, most recently
from
b8d9e79 to
df9c1b4
Compare
rd4398
reviewed
May 29, 2025
rd4398
reviewed
May 30, 2025
There was a problem hiding this comment.
This looks okay to me!
I would prefer if @tiran and / or @dhellmann takes a look at this as well. I will leave it to them for final approval
dhellmann
reviewed
Jun 1, 2025
dhellmann
reviewed
Jun 2, 2025
|
I need to add retry for Gitlab, now it has merged |
dhellmann
approved these changes
Jun 2, 2025
|
@Mergifyio refresh |
✅ Pull request refreshed |
ah thanks, I wasn't sure what to do 😄 |
|
I think this needs to be rebased to run the new tests and merge automatically. @Mergifyio rebase |
|
@Mergifyio rebase |
Add robust HTTP retry functionality to handle network errors and improve reliability when communicating with external services like GitHub API and PyPI. This addresses common issues with HTTP 504 Gateway Timeout errors, IncompleteRead, and ChunkedEncodingError exceptions. Signed-off-by: Emilien Macchi <[email protected]>
✅ Branch has been successfully rebased |
|
I guess you have to give mergify instructions without preceding comments. 🤷🏼 |
|
I got the mergify rules wrong in a previous PR. I'm merging this by hand and I will fix the rules in a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add robust HTTP retry functionality to handle network errors and improve
reliability when communicating with external services like GitHub API and
PyPI. This addresses common issues with HTTP exceptions I've seen in our CI pipelines.
Signed-off-by: Emilien Macchi [email protected]
Fixes #222