Increase logging for external commands #647
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm investigating a vLLM build problem and could not figure out the exact build environment from our build logs. This PR includes all build environment variables in the global log and the run log. |
tiran
force-pushed
the
debug-external-command
branch
from
a23bd17 to
29aec4f
Compare
|
@tiran is there any risk to expose secret environments in CI logs, e.g. credentials embedded in URLs, or secrets? etc. |
tiran
force-pushed
the
debug-external-command
branch
from
29aec4f to
b431951
Compare
That is a good point! GitHub and GitLab already mask sensitive values. I have added additional code to also mask keys that look like they hold sensitive values. |
tiran
force-pushed
the
debug-external-command
branch
from
b431951 to
876f694
Compare
tiran
force-pushed
the
debug-external-command
branch
from
876f694 to
e59971b
Compare
EmilienM
approved these changes
Jun 27, 2025
dhellmann
reviewed
Jun 27, 2025
The `external_commands.run()` function now logs all environment variables. Before it only logged extra environment variables defined in a plugin. The logs were missing information about global environment variables, e.g. env vars defined in a build container. These additional env vars influence a build, too. The run log file now contains the command, env vars, and current working directory, too. Potentially sensitive env vars are masked. This is an additional precaution. GitHub and GitLab already mask sensitive values in logs. Signed-off-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
debug-external-command
branch
from
e59971b to
7a8dcd7
Compare
dhellmann
reviewed
Jul 1, 2025
|
|
||
| # *PAT (GitLab), SECRET, PASSWORD, PASSPHRASE, CRED(entials), TOKEN | ||
| SENSITIVE_KEYS = re.compile( | ||
| "^(*.PAT|.*SECRET.*|.*PASSWORD.*|.*PASSPHRASE.*|.*CRED.*|.*TOKEN.*)$", |
There was a problem hiding this comment.
Suggested change
| "^(*.PAT|.*SECRET.*|.*PASSWORD.*|.*PASSPHRASE.*|.*CRED.*|.*TOKEN.*)$", | |
| "^(.*PAT|.*SECRET.*|.*PASSWORD.*|.*PASSPHRASE.*|.*CRED.*|.*TOKEN.*)$", |
I think the tests are failing because of a typo here in the regex that makes it look like a glob pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
external_commands.run()function now logs all environment variables. Before it only logged extra environment variables defined in a plugin. The logs were missing information about global environment variables, e.g. env vars defined in a build container. These additional env vars influence a build, too.The run log file now contains the command, env vars, and current working directory, too.
Potentially sensitive env vars are masked. This is an additional precaution. GitHub and GitLab already mask sensitive values in logs.