fix: propagate exceptions in Bootstrapper._build_sdist to fail on sdist build errors #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rd4398
reviewed
Jun 27, 2025
…st build errors Previously, _build_sdist() would catch and log all exceptions, causing the build to continue even if building the source distribution failed. This could result in undefined or misleading behavior. Now, exceptions are allowed to propagate, ensuring that build failures are reported and handled properly. Fixes python-wheel-build#637 Signed-off-by: Emilien Macchi <[email protected]>
dhellmann
requested changes
Jun 27, 2025
There was a problem hiding this comment.
We need to test this change downstream. I'm worried that we may have some packages for which building an sdist does not work but building the wheel does. If we have that, then we're going to need to continue to protect the bootstrapping process from failures here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, _build_sdist() would catch and log all exceptions, causing the build
to continue even if building the source distribution failed. This could result in
undefined or misleading behavior. Now, exceptions are allowed to propagate,
ensuring that build failures are reported and handled properly.
Fixes #637
Signed-off-by: Emilien Macchi [email protected]