Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/fromager/commands/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -643,13 +643,17 @@ def update_progressbar_cb(future: concurrent.futures.Future) -> None:
with req_ctxvar_context(
Requirement(node.canonicalized_name), node.version
):
# Get all build dependencies (build-system, build-backend, build-sdist)
# Get all dependencies. If package A needs package B to be
# installed, package B should not have a build dependency on
# package A. So, building the installation dependencies of a
# package before we build that package should be possible,
# and doing so ensures that when we mark a package as ready
# to be used for building other packages, all of the
# installation dependencies are also ready.
build_deps: DependencyNodeList = [
edge.destination_node
for edge in node.children
if edge.req_type.is_build_requirement
edge.destination_node for edge in node.children
]
# A node can be built when all of its build dependencies are built
# A node can be built when all of its dependencies are built
unbuilt_deps: set[str] = set(
dep.key for dep in build_deps if dep.key not in built_node_keys
)
Expand Down
Loading