fix(resolver): redesign resolver cache #793
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dhellmann
reviewed
Sep 27, 2025
tiran
force-pushed
the
resolver-cache
branch
2 times, most recently
from
06cd5ce to
2bc01ea
Compare
|
It looks like ruff is not happy with the formatting of a file |
Redesign the resolver cache to address multiple issues. 1. The cache now holds all candidates from the provider. Before it only stored candidates that also fulfilled the requirement and constraints. 2. The cache now takes sdist url, GitHub repo, and GitLab project into account. Before a cache for local PyPI and pypi.org were mixed. 3. GenericProvider no longer caches candidates. There is no way to construct a good cache key. Bootstrapper is using GenericProvider in way that does not benefit from caching either. 4. There is just one global cache object for all providers. The new design makes it easier to clear all caches or just the cache for a single identifier. 5. The custom logic for each provider class is now in `find_candidates` function. The method just has to return an iterable of candidates. The caching logic is handled by the rest of the code. 6. Consumers can now opt out of caching with `use_resolver_cache=False` argument. 7. All resolver classes now require keyword arguments. The base provider no longer takes PyPI-only arguments like `include_sdists`. Fixes: python-wheel-build#766 Signed-off-by: Christian Heimes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesign the resolver cache to address multiple issues.
find_candidatesfunction. The method just has to return an iterable of candidates. The caching logic is handled by the rest of the code.use_resolver_cache=Falseargument.include_sdists.Fixes: #766