-
Couldn't load subscription status.
- Fork 31
feat(settings): add version-specific prebuilt wheel configuration #800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pmattsso
wants to merge
1
commit into
python-wheel-build:main
Choose a base branch
from
pmattsso:versionsettings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| Version-Specific Prebuilt Settings | ||
| =================================== | ||
|
|
||
| When working with multiple collections that share the same variant but need | ||
| different versions of a package, you may want some versions to use prebuilt | ||
| wheels while others are built from source. | ||
|
|
||
| Version-specific prebuilt settings allow you to configure ``pre_built`` and | ||
| ``wheel_server_url`` on a per-version basis within a variant, providing | ||
| fine-grained control over which package versions use prebuilt wheels. | ||
|
|
||
| Configuration | ||
| ------------- | ||
|
|
||
| Add version-specific settings under the ``versions`` key within a variant: | ||
|
|
||
| .. code-block:: yaml | ||
|
|
||
| # overrides/settings/torchvision.yaml | ||
| variants: | ||
| tpu-ubi9: | ||
| # Default behavior for unlisted versions | ||
| pre_built: false | ||
|
|
||
| # Version-specific overrides | ||
| versions: | ||
| # Use prebuilt wheel for this version | ||
| "0.24.0.dev20250730": | ||
| pre_built: true | ||
| wheel_server_url: https://gitlab.com/api/v4/projects/12345/packages/pypi/simple | ||
|
|
||
| # Build from source for this version | ||
| "0.23.0": | ||
| pre_built: false | ||
|
|
||
| Available Settings | ||
| ------------------ | ||
|
|
||
| Within each version-specific block, you can configure: | ||
|
|
||
| ``pre_built`` | ||
| Boolean indicating whether to use prebuilt wheels for this version. | ||
|
|
||
| ``wheel_server_url`` | ||
| URL to download prebuilt wheels from for this version. | ||
|
|
||
| ``env`` | ||
| Environment variables specific to this version. | ||
|
|
||
| ``annotations`` | ||
| Version-specific annotations. | ||
|
|
||
| Precedence Rules | ||
| ---------------- | ||
|
|
||
| Version-specific settings override variant-wide settings. If both are defined, | ||
| environment variables are merged with version-specific values taking precedence | ||
| for conflicting keys. | ||
|
|
||
| Example Use Case | ||
| ---------------- | ||
|
|
||
| Consider two TPU collections using different ``torchvision`` versions: | ||
|
|
||
| **Global Collection** (``collections/accelerated/tpu-ubi9/requirements.txt``): | ||
|
|
||
| .. code-block:: text | ||
|
|
||
| torchvision==0.24.0.dev20250730 | ||
|
|
||
| **Torch-2.8.0 Collection** (``collections/torch-2.8.0/tpu-ubi9/requirements.txt``): | ||
|
|
||
| .. code-block:: text | ||
|
|
||
| torchvision==0.23.0 | ||
|
|
||
| With the configuration above: | ||
|
|
||
| - Global collection downloads prebuilt ``torchvision==0.24.0.dev20250730`` wheels | ||
| - Torch-2.8.0 collection builds ``torchvision==0.23.0`` from source | ||
| - Both use the same variant (``tpu-ubi9``) with different build methods |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is going to be messier than I thought.
The
_psfield really should be private to the PBI. We could at least wrap this logic in a method, but it's odd to need to know about the version-specific prebuilt flags before we resolve the version we're going to bootstrapping.I don't remember why we have different logic for resolving versions of prebuilt wheels. How different is that logic from the other flow? Does it skip some steps or are there completely different steps?