feat: add constraints to graph files #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add constraint field to dependency graph nodes to record which constraint rules were applied to each package during the build. This makes it easier to understand and debug builds by preserving the constraint information that influenced version resolution. Changes: - Add constraint field to DependencyNode and DependencyNodeDict - Update add_dependency() to accept and store constraint parameter - Modify bootstrapper to retrieve and pass constraint rules - Update bootstrap command to include constraints for top-level deps - Maintain backward compatibility for loading old graph files - Update tests to include constraint field in assertions The constraint field defaults to an empty string when no constraint is applied, and old graph files without this field can still be loaded successfully. Closes: python-wheel-build#813 Chat transcript: https://gist.github.com/dhellmann/804bb6128189e8585adfdfba97d70326 Co-authored-by: Claude 3.5 Sonnet (Anthropic AI Assistant) via Cursor Signed-off-by: Doug Hellmann <[email protected]>
Update graph subcommands to show constraint information when analyzing
dependencies, making it easier to understand which constraints influenced
version selection during builds.
Changes to explain-duplicates:
- Show constraint once at package name level (not per-version)
- Constraint from first node used since all versions share same constraint
- Results in cleaner, less repetitive output
Changes to why command:
- Show constraint for queried package at depth 0
- Show constraint for parent packages in dependency relationships
- Show constraint for top-level dependencies
Example output for explain-duplicates:
package-b (constraint: package-b>=1.0,<2.0)
1.0.0
2.0.0
Example output for why command:
child-pkg==1.5.0 (constraint: child-pkg>=1.0,<2.0)
* child-pkg==1.5.0 is an install dependency of parent-pkg==1.0.0 (constraint: parent-pkg==1.0.0)
* toplevel-pkg==2.0.0 (constraint: toplevel-pkg>=2.0,<3.0) is a toplevel dependency
Added comprehensive test coverage for both commands with and without
constraints to ensure graceful handling of all scenarios.
Chat transcript: https://gist.github.com/dhellmann/804bb6128189e8585adfdfba97d70326
Co-authored-by: Claude 3.5 Sonnet (Anthropic AI Assistant) via Cursor
Signed-off-by: Doug Hellmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save the constraints used during bootstrapping to the graph file so they are available when debugging later.
Update the graph commands explain-duplicates and why to include the constraint information, when it is present in the graph file.
Chat transcript: https://gist.github.com/dhellmann/804bb6128189e8585adfdfba97d70326
Closes #813
Co-authored-by: Claude 3.5 Sonnet (Anthropic AI Assistant) via Cursor