Skip to content

Conversation

JacobCoffee
Copy link
Member

What

  • Sources a security policy so that users (hopefully) do not create issues on this repo

Why

  • There isn't one
  • Clear communication for users to see how to report potential security issues

See Also

python/pythondotorg#2417

@hugovk
Copy link
Member

hugovk commented Apr 24, 2024

This PR will add links for all repos under https://github.com/python to the security policy:

The policy at https://www.python.org/dev/security/ says it only covers official CPython and pip.

It doesn't mention other projects under https://github.com/python, such as mypy, blurb, pyperformance and tzdata: https://github.com/orgs/python/repositories?type=all

I think it's reasonable to include those, but let's ask the PSRT first.

the Python team responsibly.

To reach the response team, email
<a href="mailto:%73%65%63%75%72%69%74%79%40%70%79%74%68%6F%6E%2E%6F%72%67">security
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to obfuscate this?

Copy link
Member Author

@JacobCoffee JacobCoffee Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't mind, my suggestion was to copy https://www.python.org/dev/security/, there must have been a reason to do it there 🤷

Co-authored-by: Jelle Zijlstra <[email protected]>
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JacobCoffee welcome, nice to see you here 👋

Applying this to the whole org will also impact projects like mypy / typeshed / typing_extensions / multiple others.

Is it correct? Do we expect all security notices about these project to be reported the same way?

@hugovk
Copy link
Member

hugovk commented Apr 24, 2024

Yes, it would show up on all repos under https://github.com/python.

I've asked the PSRT to confirm they're fine with it, and a couple of mypy maintainers said they'd be happy to receive reports via the PSRT. (Mypy being the most likely to receive security reports.)

@JacobCoffee
Copy link
Member Author

Any news @hugovk ?

@hugovk
Copy link
Member

hugovk commented Jul 29, 2024

It was generally positive but nothing definitive so I've asked again.

Copy link

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After asking again there was no pushback from the PSRT on adopting this, let's add it.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have marge rights here.

@Mariatta Please could you do the honours? Thanks!

@JacobCoffee
Copy link
Member Author

Do I need to merge this? I don't mind, just don't want to step on anyones toes.

@hugovk
Copy link
Member

hugovk commented Sep 9, 2024

Go for it!

@JacobCoffee JacobCoffee merged commit f946813 into python:master Sep 9, 2024
@JacobCoffee JacobCoffee deleted the security branch September 9, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants