Improvements to the Emscripten buildbot#687
Conversation
* Use the build script from its new `Platform/emscripten/__main__.py` location * Use `python3 Platform/emscripten run` to avoid hard coding build output path * Use new `EMSDK_CACHE` environment variable to allow build script to manage Emscripten installations * Build libmpdec * Cache libffi and libmpdec * Allow build script to manage node installations python/cpython#146156 has to land first
hoodmane
force-pushed
the
emscripten-buildbot-improvements
branch
from
96780ff to
d8ed65b
Compare
It landed, but its 3.14 backport didn't land yet: python/cpython#146159 |
|
I guess we'll also want to merge and backport python/cpython#146158 and python/cpython#146160 first so we can move more configuration from here into the cpython repo. |
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
One typo; but otherwise this looks good to me. All the upstream PRs have landed, including 3.14 backports; and I've manually tested the commands on the buildbot.
Ok. I merged the PR (the new config will be deployed in a few minutes). Let's see how it goes :-) |
|
Thanks @vstinner! |
|
Well it is not quite right: |
|
Looks working now: |
3 participants
Platform/emscripten/__main__.pylocationpython3 Platform/emscripten runto avoid hard coding build output pathEMSDK_CACHEenvironment variable to allow build script to manageEmscripten installations
python/cpython#146156 has to land first