Skip to content

Commit 7840b37

Browse files
committed
Address code review
1 parent 8035854 commit 7840b37

File tree

5 files changed

+14
-3
lines changed

5 files changed

+14
-3
lines changed

Include/internal/pycore_opcode_metadata.h

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Include/internal/pycore_uop_metadata.h

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Python/bytecodes.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1169,7 +1169,8 @@ dummy_func(
11691169
PyStackRef_AsPyObjectSteal(sub),
11701170
PyStackRef_AsPyObjectSteal(value));
11711171
if (err) {
1172-
ERROR_NO_POP();
1172+
PyStackRef_CLOSE(dict_st);
1173+
ERROR_IF(1);
11731174
}
11741175
DEAD(dict_st);
11751176
st = dict_st;

Python/executor_cases.c.h

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Python/generated_cases.c.h

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)