Skip to content

gh-106693: Explicitly mark ob_sval as unsigned char to avoid UB #106826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-106693: Explicitly mark ob_sval as unsigned char to avoid UB #106826

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eecd6a8
gh-106693: Explicitly mark ob_sval as unsigned char to avoid UB
pablogsal Jul 17, 2023
a97c083
Merge branch 'main' into gh-106693
pablogsal Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Include/cpython/bytesobject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
typedef struct {
PyObject_VAR_HEAD
Py_DEPRECATED(3.11) Py_hash_t ob_shash;
char ob_sval[1];
unsigned char ob_sval[1];

/* Invariants:
* ob_sval contains space for 'ob_size+1' elements.
Expand All @@ -20,11 +20,11 @@
#define _PyBytes_CAST(op) \
(assert(PyBytes_Check(op)), _Py_CAST(PyBytesObject*, op))

static inline char* PyBytes_AS_STRING(PyObject *op)
static inline unsigned char* PyBytes_AS_STRING(PyObject *op)
{
return _PyBytes_CAST(op)->ob_sval;
}
#define PyBytes_AS_STRING(op) PyBytes_AS_STRING(_PyObject_CAST(op))

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

pointer targets in passing argument 1 of ‘_PyLong_FromBytes’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

pointer targets in passing argument 1 of ‘_PyLong_FromBytes’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

pointer targets in passing argument 1 of ‘PyUnicode_Decode’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

pointer targets in initialization of ‘const char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

pointer targets in passing argument 1 of ‘PyUnicode_Decode’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

pointer targets in passing argument 1 of ‘PyUnicode_Decode’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

pointer targets in passing argument 1 of ‘_PyLong_FromBytes’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

pointer targets in passing argument 1 of ‘_PyLong_FromBytes’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

pointer targets in passing argument 1 of ‘PyUnicode_Decode’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

pointer targets in initialization of ‘const char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) 

pointer targets in passing argument 1 of ‘PyUnicode_Decode’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

pointer targets in passing argument 1 of ‘_PyLong_FromBytes’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

pointer targets in passing argument 1 of ‘PyUnicode_Decode’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

pointer targets in initialization of ‘const char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

pointer targets in passing argument 1 of ‘PyUnicode_Decode’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

pointer targets in initialization of ‘char *’ from ‘unsigned char *’ differ in signedness [-Wpointer-sign]

Check warning on line 27 in Include/cpython/bytesobject.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

pointer targets in passing argument 1 of ‘PyUnicode_Decode’ differ in signedness [-Wpointer-sign]

static inline Py_ssize_t PyBytes_GET_SIZE(PyObject *op) {
PyBytesObject *self = _PyBytes_CAST(op);
Expand Down
Loading