Skip to content

gh-106670: Fix Pdb handling of chained Exceptions with no stacks. #108865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 6, 2023
Merged

gh-106670: Fix Pdb handling of chained Exceptions with no stacks. #108865

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b0c7dbd
gh-106670: Fix Pdb handling of chained Exceptions with no stacks.
Carreau Sep 4, 2023
3607006
change wording of exception
Carreau Sep 4, 2023
fbd394d
take comments into account
Carreau Sep 4, 2023
b138dde
Try to handle exceptions without traceback
Carreau Sep 5, 2023
7b697f1
introduce private _post_mortem
Carreau Sep 5, 2023
e47906c
Update Lib/pdb.py
Carreau Sep 5, 2023
02f5b32
Update Lib/pdb.py
Carreau Sep 5, 2023
087e39a
protect interaction, if an exception is given and has not tb jumpt to…
Carreau Sep 5, 2023
c69a3b7
Merge remote-tracking branch 'github/fix-pdb-no-tb' into fix-pdb-no-tb
Carreau Sep 5, 2023
f90a453
fix wording
Carreau Sep 5, 2023
e7533c9
Update Lib/pdb.py
Carreau Sep 5, 2023
368222c
remove autoumping to last exception w/o tb
Carreau Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Lib/pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ def _get_tb_and_exceptions(self, tb_or_exc):
traceback, current = tb_or_exc.__traceback__, tb_or_exc

while current is not None:
if current in _exceptions:
if current in _exceptions or not current.__traceback__:
break
_exceptions.append(current)
if current.__cause__ is not None:
Expand Down Expand Up @@ -491,6 +491,10 @@ def interaction(self, frame, tb_or_exc):
Pdb._previous_sigint_handler = None

_chained_exceptions, tb = self._get_tb_and_exceptions(tb_or_exc)
if not _chained_exceptions and isinstance(tb_or_exc, BaseException):
raise ValueError(
"A valid traceback must be passed if no exception is being handled"
)
Copy link
Contributor Author

@Carreau Carreau Sep 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to catch this reproducer

>>> import sys
>>> import pdb
>>> sys.last_exc = Exception()
>>> pdb.pm()

It's contrived, but as it is already handled in pdb.post_mortem(), I assume there are case where this can happen in production.

with self._hold_exceptions(_chained_exceptions):
if self.setup(frame, tb):
# no interaction desired at this time (happens if .pdbrc contains
Expand Down
90 changes: 80 additions & 10 deletions Lib/test/test_pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,11 +907,18 @@ def test_post_mortem_chained():
def test_post_mortem_cause_no_context():
"""Test post mortem traceback debugging of chained exception

>>> def make_ex_with_stack(type_, *content, from_=None):
... try:
... raise type_(*content) from from_
... except Exception as out:
... return out
...

>>> def main():
... try:
... raise ValueError('Context Not Shown')
... except Exception as e1:
... raise ValueError("With Cause") from TypeError('The Cause')
... raise ValueError("With Cause") from make_ex_with_stack(TypeError,'The Cause')

>>> def test_function():
... import pdb;
Expand All @@ -925,6 +932,7 @@ def test_post_mortem_cause_no_context():

>>> with PdbTestInput([ # doctest: +ELLIPSIS, +NORMALIZE_WHITESPACE
... 'exceptions',
... 'exceptions 0',
... 'exceptions 1',
... 'up',
... 'down',
Expand All @@ -934,20 +942,23 @@ def test_post_mortem_cause_no_context():
... test_function()
... except ValueError:
... print('Ok.')
> <doctest test.test_pdb.test_post_mortem_cause_no_context[0]>(5)main()
-> raise ValueError("With Cause") from TypeError('The Cause')
> <doctest test.test_pdb.test_post_mortem_cause_no_context[1]>(5)main()
-> raise ValueError("With Cause") from make_ex_with_stack(TypeError,'The Cause')
(Pdb) exceptions
0 TypeError('The Cause')
> 1 ValueError('With Cause')
0 TypeError('The Cause')
> 1 ValueError('With Cause')
(Pdb) exceptions 0
> <doctest test.test_pdb.test_post_mortem_cause_no_context[0]>(3)make_ex_with_stack()
-> raise type_(*content) from from_
(Pdb) exceptions 1
> <doctest test.test_pdb.test_post_mortem_cause_no_context[0]>(5)main()
-> raise ValueError("With Cause") from TypeError('The Cause')
> <doctest test.test_pdb.test_post_mortem_cause_no_context[1]>(5)main()
-> raise ValueError("With Cause") from make_ex_with_stack(TypeError,'The Cause')
(Pdb) up
> <doctest test.test_pdb.test_post_mortem_cause_no_context[1]>(5)test_function()
> <doctest test.test_pdb.test_post_mortem_cause_no_context[2]>(5)test_function()
-> main()
(Pdb) down
> <doctest test.test_pdb.test_post_mortem_cause_no_context[0]>(5)main()
-> raise ValueError("With Cause") from TypeError('The Cause')
> <doctest test.test_pdb.test_post_mortem_cause_no_context[1]>(5)main()
-> raise ValueError("With Cause") from make_ex_with_stack(TypeError,'The Cause')
(Pdb) exit"""


Expand Down Expand Up @@ -1066,6 +1077,65 @@ def test_post_mortem_from_none():
"""


def test_post_mortem_from_no_stack():
"""Test post mortem traceback debugging of chained exception

especially when one exception has not stack.

>>> def main():
... raise Exception() from Exception()


>>> def test_function():
... import pdb;
... instance = pdb.Pdb(nosigint=True, readrc=False)
... try:
... main()
... except Exception as e:
... # same as pdb.post_mortem(e), but with custom pdb instance.
... instance.reset()
... instance.interaction(None, e)

>>> with PdbTestInput( # doctest: +ELLIPSIS, +NORMALIZE_WHITESPACE
... ["exceptions",
... "exit"],
... ):
... try:
... test_function()
... except ValueError:
... print('Correctly reraised.')
> <doctest test.test_pdb.test_post_mortem_from_no_stack[0]>(2)main()
-> raise Exception() from Exception()
(Pdb) exceptions
> 0 Exception()
(Pdb) exit
"""


def test_post_mortem_single_no_stack():
"""Test post mortem called when origin exception has not stack


>>> def test_function():
... import pdb;
... instance = pdb.Pdb(nosigint=True, readrc=False)
... import sys
... sys.last_exc = Exception()
... # same as pdb.post_mortem(e), but with custom pdb instance.
... instance.reset()
... instance.interaction(None, sys.last_exc)

>>> with PdbTestInput( # doctest: +ELLIPSIS, +NORMALIZE_WHITESPACE
... []
... ):
... try:
... test_function()
... except ValueError as e:
... print(e)
A valid traceback must be passed if no exception is being handled
"""


def test_post_mortem_complex():
"""Test post mortem traceback debugging of chained exception

Expand Down