gh-96694: add F_GETLK wrapper in fcntl module #112372
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eqvinox
force-pushed
the
fcntl-getlk-202311
branch
from
7460cc3 to
e4097fe
Compare
|
No idea how to get someone to review this… I'd really like to stop mucking around with @serhiy-storchaka can you look at this? It's a really simple wrapper and has an unit test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of #96695, not sure who to bribe to make anything happen here?
Not much to say here, just an added wrapper to do
fcntl(F_GETLK)without having to muck aroundstruct.unpackFirst PR, feedback very welcome.
fcntlmodule provides no access to F_GETLK operation #96694📚 Documentation preview 📚: https://cpython-previews--112372.org.readthedocs.build/