Skip to content

gh-112636: remove check for float subclasses without nb_float #112637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

gh-112636: remove check for float subclasses without nb_float #112637

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
56d7b83
gh-112636: remove check for float subclasses without nb_float
skirpichev Dec 3, 2023
8a0a04d
+ news
skirpichev Oct 1, 2024
85e3df0
Merge branch 'main' into fix-112636-nb_float
skirpichev Oct 1, 2024
7f14215
Apply suggestions from code review
skirpichev Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Objects/abstract.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1737,10 +1737,6 @@ PyNumber_Float(PyObject *o)
return PyFloat_FromDouble(val);
}

/* A float subclass with nb_float == NULL */
if (PyFloat_Check(o)) {
return PyFloat_FromDouble(PyFloat_AS_DOUBLE(o));
}
return PyFloat_FromString(o);
}

Expand Down