Check argument in itertools's recipe for "grouper" #112759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recipe for "grouper" has a minor bug where the "incomplete" argument wasn't checked properly
bedevere-app
bot
added
docs
Contributor
Author
|
I realized after some pondering, the code works as stated, but it is unbalanced in the sense that there are three "if"s, where only the last one has an "else". |
rhettinger
approved these changes
Dec 5, 2023
|
Thanks @jneb for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
rhettinger
added
needs backport to 3.12
|
Thanks @jneb for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
rhettinger
pushed a commit
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recipe for "grouper" has a minor bug where the "incomplete" argument wasn't checked properly
This can be trivially fixed by changing just two lines, replacing "if" by "elif".
📚 Documentation preview 📚: https://cpython-previews--112759.org.readthedocs.build/