-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
gh-56634: Gettext: raise descriptive ValueError
s instead of IndexError
s for incorrect .mo
files metadata
#112895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
m-aciek
wants to merge
15
commits into
python:main
Choose a base branch
from
m-aciek:gettext-handle-incorrect-plural-forms
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
gh-56634: Gettext: raise descriptive ValueError
s instead of IndexError
s for incorrect .mo
files metadata
#112895
m-aciek
wants to merge
15
commits into
python:main
from
m-aciek:gettext-handle-incorrect-plural-forms
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2515c9
to
17baf50
Compare
17baf50
to
e38c34c
Compare
e38c34c
to
e148f83
Compare
michalbon
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add similar change for content-type?
.mo
files metadata parsing
.mo
files metadata parsingValueError
s instead of IndexError
s for incorrect .mo
files metadata
@serhiy-storchaka Would it be possible for you to find a spare moment for a re-review? Thank you! |
(Fixed Windows support in tests.) |
Misc/NEWS.d/next/Library/2025-09-25-21-13-59.gh-issue-56634.8tySiu.rst
Outdated
Show resolved
Hide resolved
…ySiu.rst Co-authored-by: Stan Ulbrych <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising
ValueError
s with descriptive error messages."Plural-Forms: \n"
(original downstream bug, and fix) but also lack ofplural=
keyword, like"Plural-Forms: nplurals=4;\n"
.ValueError: expected ';' and 'plural=' in Plural-Forms metadata in sample.mo, got ''
IndexError
ValueError: expected 'charset=' in Content-Type metadata in sample.mo, got ''
IndexError
In the #56634 ignoring the incorrect syntax was being discussed, as well as issuing warnings.
The implementation here is following the suggestion of @serhiy-storchaka of raising an error instead.