Remove misleading parts of is_site_local() documentation #113152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of IPv6Address and IPv6Network is_private is very much not an equivalent or a replacement of is_site_local(). IPv6 is_private considers many ranges other than RFC 4193's fc00::/7 to be private (see _IPv6Constants._private_networks for the complete list). IPv6Address.is_private goes even further and delegates to IPv4Address.is_private in case of an IPv4-mapped IPv6 address.
|
Seems like a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of IPv6Address and IPv6Network is_private is very much not an equivalent or a replacement of is_site_local().
IPv6 is_private considers many ranges other than RFC 4193's fc00::/7 to be private (see _IPv6Constants._private_networks for the complete list).
IPv6Address.is_private goes even further and delegates to IPv4Address.is_private in case of an IPv4-mapped IPv6 address.
📚 Documentation preview 📚: https://cpython-previews--113152.org.readthedocs.build/